The code that allegedly broke the Zune

midoriw:

marco:

Via jstn.

while (days > 365) {
    if (IsLeapYear(year)) {
        if (days > 366) {
            days -= 366;
            year += 1;
        }
    } else {
        days -= 365;
        year += 1;
    }
}

Out of curiosity, why was this being rewritten by Freescale or Microsoft at all? This has been a solved problem for a very long time.

(Also, this is very ugly C style in many places. I expected better from Microsoft.)

Also, who hard-codes magic numbers like that? So many things wrong with this picture.

Comments (View) | 
  1. snippet reblogged this from jstn
  2. allincircles reblogged this from marco
  3. chancegarcia reblogged this from trotzke
  4. lanceturner reblogged this from jstn
  5. trotzke reblogged this from marco
  6. romansang-marino reblogged this from ratatat
  7. ratatat reblogged this from marco
  8. parx reblogged this from poortaste
  9. ohserena reblogged this from ledenes
  10. microblog reblogged this from marco
  11. hivelessmind reblogged this from ostermayer
  12. nerbles reblogged this from ostermayer and added:
    I am a geek for posting this, but it’s proof some of you should stop trusting ol’ Bill and buy Mac like grown-ups do. :P
  13. aladuh reblogged this from marco
  14. darknessfalls reblogged this from jstn
  15. ronworkman reblogged this from jstn
  16. nevyn reblogged this from marco and added:
    The code from where...originated is available here. The funny thing is that the same code...
  17. uninformat reblogged this from marco
  18. benglert reblogged this from midoriw and added:
    Also, who hard-codes magic numbers like that? So many things wrong with this picture.
  19. rebloghaven reblogged this from marco
  20. angstinmypants reblogged this from tristn and added:
    HOLY SHIT I actually understand all of this. Maybe I learned something from Dr Schwartz after all and therefore should...
  21. tristn reblogged this from inothernews and added:
    I take it “days > 366” should be “days >= 366”.
  22. midoriw reblogged this from marco
  23. deadlybrad42 reblogged this from poortaste and added:
    I thought we were beyond these kind of coding errors. Anyways, here’s an explanation for people who don’t read code.
  24. shabdar reblogged this from marco and added:
    “I expect” is...diffrent story! Microsoft...like a hot...
  25. marco reblogged this from jstn and added:
    Out of curiosity, why was this being rewritten by Freescale or Microsoft at all? This has been a solved problem for a...
  26. inothernews reblogged this from ledenes
  27. ledenes reblogged this from ryanjpointer
  28. ryanjpointer reblogged this from jstn
  29. poortaste reblogged this from jstn
  30. sparo reblogged this from jstn
  31. jstn posted this